GitLab issue 652 Copying activity file custom data doesn't copy mime … #13427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
GitLab Issue 652 Copying activity file custom data doesn't copy mime type
Before
After
copyExtendedActivityData()
method in CRM/Activity/BAO/Activity.php 'path' was renamed to 'type' in the following coding blockTechnical Details
copyExtendedActivityData()
method in CRM/Activity/BAO/Activity.php 'path' should be renamed to 'type' in the following coding blockformatCustomField()
method in CRM/Core/BAO/CustomField.php, the mimeType variable uses 'type' not pathpath()
method in CRM/Core/BAO/File.php which is used bycopyExtendedActivityData()
returns path and mime typeComments